Thank god nobody mentioned the “Dosti” pair.
How about Dharmendra and Rehman in Dil ne phir yaad kiya? *lol*

Sholay, DCH, Rang De Basanti (this film reminds of the kind of friends I have and would love to have more of), Hera Pheri (my memories are vague but I remember adoring Akshay-Sunil), Saif-Akshay in Keemat, Dharam-Amitabh in Chupke Chupke, Mangal Pandey, Dharam-Veer, JBDY..

I didn’t absolutely adore The Burning Train but Dharam-Vinod were pretty awesome in it, yes.

And I must second tao paipai’s Kollywood pick of Pithamagan. :)

Other commenters have already mentioned some of my favourite male buddy roles: Dharmendra and Vinod in ‘The Burning Train’, which is my absolute favourite Dhamendra movie; the guys from ‘Dil Chahta Hai’, the guys from ‘Partner’ (I also liked the friendship between Akshay Kumar, Riteish Deshmukh and Fardeen Khan in ‘Heyy Babyy’ – there’s a lot about the film that’s so… wrong, but I liked the ‘realness’ of the friendship), SRK and Shreyas Talpade in ‘Om Shanti Om’.

And more great ones from tao paipai (I do so wish I could read your blog ;-)

I simply adore Vinod-Amitabh duo, so most of my buddy types will be from their films :).
First of all – V & A in funny “Hera Pheri” – for me it’s an epitome of friendship. Or something even more then friendship ;]. Then guys in stylish “Khoon Pasina”, mischievous “Zameer” (however Vinod’s part here is very small) and tragic “Muqaddar ka Sikandar” – in all these films there’s pure chemistry between them!

&
(obviously) Dharam & Amit in eternal “Sholay”
Dharam & Vinod in my beloved “Burning Train”
Vinod & Kabir Bedi in dacoit “Kuchhe Dhaage” (their relation here is quite strange and it’s rather hard to call it friendship, but still it’s very interesting :))
Vinod & Feroz (& Amjad Khan ;D) in “Qurbani” (although Feroz is not as emotional as he should be)
Aamir & Toby in “Mangal Pandey”

And one type from Kollywood – Vikram & Surya in heartrending and totally depressing (but beautiful) “Pithamagan”.